Pybind11 quick fix

[MonkeyBreaker]

Reference issues/PRs

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Latest pybind11:master does not compile anymore on any OS, even on my machine. I'm currently looking into a solution why CMakeLists.txt is wrongly configured. On the meantime, this PR fix the issue of pybind11 by checking out latest stable version v2.5.0.

Screenshots (if appropriate)

Any other comments?

I'll be on holidays in the following days, I don't think I'll be able to have a better solution until I'm back.

If you encounter a problem when building locally due to pybind11. Remove build and gtda/externals/pybind11 folders before running again the building process.

Another thing, to prevent this unexpected issues in the future, we should block to a specific version and each X months try to update and fix eventual issues. What do you think ?

Checklist

• [x] I have read the guidelines for contributing.
• [x] My code follows the code style of this project. I used flake8 to check my Python changes.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed. I used pytest to check this on Python tests.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[MonkeyBreaker]

@ulupo & @wreise Hi everyone, This PR is a really quick fix about the building issues encountered on the pipeline. I also encounter this issues on my machine, with the latest master of pybind11.

Unfortunately I'm on holidays next week, I'll try to fix better the issue today, but on the meantime this "fix" allows the pipeline and the user to build the library.

Let me know if you need more details or I should add some changes !

[ulupo]

@MonkeyBreaker thanks a million for this! Especially during a weekend and just before your holidays! I agree that we should fix versions to avoid similar issues in future.