giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
858 stars 175 forks source link

Fix handling of COO matrices by ripser, mirroring https://github.com/scikit-tda/ripser.py/pull/104 #465

Closed ulupo closed 4 years ago

ulupo commented 4 years ago

Reference issues/PRs Fixes the analogous issue to https://github.com/scikit-tda/ripser.py/issues/103. The fix is a replica of https://github.com/scikit-tda/ripser.py/pull/104.

Types of changes

Description See https://github.com/scikit-tda/ripser.py/issues/103 and https://github.com/scikit-tda/ripser.py/pull/104. Note that an alternative would have been to first convert to another sparse format (e.g. CSR) and then to COO again. But this is slower unless the input is very large.

Checklist