Closed reds-heig closed 4 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: ulupo
:x: julian
@ulupo I think that this PR should only update the Gudhi bindings, and in a different PR, we should integrate the Collapser bindings for python, what do you think ?
Totally agree!
Is the plan to include the collapser as an invisible step in each of the persistence transformer? This seems to be such an amazing achievement from the GUDHI team, I am really looking forward to trying it out!
@gtauzin as far as I understand it, the collapser only works on flag complexes, so we would presumably only offer it for VietorisRipsPersistence
(and maybe FlagserPersistence
when directed
is False
; WeakAlphaPersistence
should be fast enough without it). I don't know about SparseRipsPersistence
, but we could look into it.
Reference issues/PRs Supersedes #466. Partially addresses #307.
Types of changes
Description
This PR integrates latest changes on
gudhi
modules, it also add the c++ code for the newCollapser
feature.Latest version of
Gudhi
requiresEigen
as a dependency, fortunately, Eigen is aheader
only library, and we where able to add it as agit submodule
directly.Also integrating changes from @ulupo of
setup.py
,azure-pipelines.yml
anddocker_scripts.sh
Screenshots (if appropriate)
Any other comments?
@ulupo I think that this PR should only update the
Gudhi
bindings, and in a different PR, we should integrate theCollapser
bindings for python, what do you think ?Checklist
flake8
to check my Python changes.pytest
to check this on Python tests.