giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
845 stars 173 forks source link

Change default value of nan_fill_value in PersistenceEntropy to -1 #474

Closed ulupo closed 4 years ago

ulupo commented 4 years ago

Reference issues/PRs

450

Types of changes

Description Favours a default value of nan_fill_value which is guaranteed not to break a pipeline in downstream tasks. -1. is negative and hence cannot be an entropy. None is still available to the user, at their own risk.

Checklist