TransformerResamplerMixin notebook, make Labeller.transform return 1D arrays

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python

https://giotto-ai.github.io/gtda-docs

Other

858 stars 175 forks source link

Closed ulupo closed 4 years ago

ulupo commented 4 years ago

Adds a notebook explaining about the TransformerResamplerMixin and giotto pipeline API in the context of doing time series forecasting.

Also introduces a breaking change by making the output of Labeller.transform a 1D array instead of a column array.

review-notebook-app[bot] commented 4 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

lewtun commented 4 years ago

This is a great notebook @ulupo! I just made some small grammatical suggestions / typo fixing

ulupo commented 4 years ago

@lewtun thanks for the review!

Note to self: Use graphical printed representations of pipelines as per scikit-learn 0.23. Use slicing notation to show intermediate steps.

lewtun commented 4 years ago

Overall LGTM! Good note to self :)