giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
858 stars 175 forks source link

Add a curves module and a StandardFeatures transformer to extract features from them #480

Closed gtauzin closed 4 years ago

gtauzin commented 4 years ago

Reference issues/PRs

Types of changes

Description

Screenshots (if appropriate)

Any other comments?

Checklist

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

gtauzin commented 4 years ago

Just requiring you review for the curves.StandardFeature transformer.

gtauzin commented 4 years ago

@ulupo @wreise Ready for a full review!

gtauzin commented 4 years ago

Note to self add module to main init and to documentation.

gtauzin commented 4 years ago

@ulupo I know you want to suggest to keep PersistenceLandascape and flatten all nd arrays into 2darrays here xD

ulupo commented 4 years ago

Note to self: Check PersistenceLandscape documentation again.

gtauzin commented 4 years ago

@ulupo I have an idea to greatly simplify hyperparams validation. Once the agreed changes are made, I will give it a try!

ulupo commented 4 years ago

@gtauzin ok cool! I'll give you a signal when I'm done with the changes.