giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
845 stars 173 forks source link

Outdated code in Stock Market Crash Detection #504

Closed sparvaneh closed 4 years ago

sparvaneh commented 4 years ago

I am getting error message ImportError: cannot import name 'check_diagram' from 'gtda.utils.validation' while tried to run Stock Market Crash Detection example Windows 10 Python 3,7

How can I resolve the issue?

ulupo commented 4 years ago

Hey @sparvaneh, thanks for reaching out! Unfortunately, many of the notebooks outside this repo (such as the one on stock market crashes you mention) were written using old versions of giotto-tda. It should not require too much effort to modify them to the latest version of the library, however. If you are using giotto-tda v0.2.2, please consult https://giotto-ai.github.io/gtda-docs/0.2.2/library.html.

For instance, check_diagram is now called check_diagrams.

Closing as this is not an issue concerning the giotto-tda project.