Fix precomputed behaviour in KNeighborsGraph - Githubissues

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python

https://giotto-ai.github.io/gtda-docs

Other

858 stars 175 forks source link

Fix precomputed behaviour in KNeighborsGraph #506

Closed ulupo closed 4 years ago

ulupo commented 4 years ago

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Avoid warnings when metric is passed as 'precomputed'
Fix errors in docstrings and improve wording
Improve tests

Checklist

[x] I have read the guidelines for contributing.
[x] My code follows the code style of this project. I used flake8 to check my Python changes.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed. I used pytest to check this on Python tests.