search

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
845 stars 173 forks source link

Line in tutorial should be changed due to not working anymore. #518

Closed Filco306 closed 3 years ago

Filco306 commented 3 years ago

https://github.com/giotto-ai/giotto-tda/blob/ef19301faa52cc66cf4e0c284d34b875345bf681/examples/mapper_quickstart.ipynb#L371

Hello,

First of all, thank you for a nice repo! I am fiddling around and discovered that this line is wrong as of version 0.2.2, with version 0.8.2 of igraph, this line should be node_elements = graph['node_metadata']["node_elements"] and not node_elements = graph.vs["node_elements"]. Just a tiny detail, but thought it might help future people!

Best,

ulupo commented 3 years ago

Hi @Filco306, and thanks for the kind words about the project. Concerning your issue, what you are pointing out is not a mistake. The point is that you are looking at the state of the master branch, which is well ahead of the 0.2.X from which release 0.2.2 was made. In other words, at all times master can be considerably far ahead relative to the latest stable release. Usually, I would tell you to install giotto-tda-nightly (https://pypi.org/project/giotto-tda-nightly/) via pip to have a version of the library that is almost in perfect sync with master. This time, however, I would instead tell you to wait until later today when release 0.3.0 will be made :).

ulupo commented 3 years ago

The (rather large!) changelog for 0.3.0 can be seen at https://github.com/giotto-ai/giotto-tda/releases/tag/untagged-5bc624a2c88e721cf434