giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
858 stars 175 forks source link

Pull ripser.py latest changes #530

Closed reds-heig closed 4 years ago

reds-heig commented 4 years ago

Reference issues/PRs

Types of changes

Description

Pull latest changes added to ripser.py, in particular via https://github.com/scikit-tda/ripser.py/pull/106. The changes concerns only performance and not functionality. This PR also add a new dependency, robinhood hashmap, which allow to speed up by around 30% the runtime.

Screenshots (if appropriate)

Any other comments?

Checklist

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ulupo commented 4 years ago

Amazing! If this is ready for you then I'll just trigger the Azure CI for the wheels (so far only the dev install has been tested) and merge if they pass.

MonkeyBreaker commented 4 years ago

Green light for me :)