Embed giotto-tda NeurIPS talk in docs home page

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python

https://giotto-ai.github.io/gtda-docs

Other

858 stars 175 forks source link

Embed giotto-tda NeurIPS talk in docs home page #565

Closed ulupo closed 3 years ago

ulupo commented 3 years ago

Reference issues/PRs

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Screenshots (if appropriate)

Any other comments?

Checklist

[ ] I have read the guidelines for contributing.
[ ] My code follows the code style of this project. I used flake8 to check my Python changes.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed. I used pytest to check this on Python tests.

ulupo commented 3 years ago

@wreise would you be able to help with this? Also would like feedback on position. My opinion is that the video should be quite prominent at the very top of the landing page.

wreise commented 3 years ago

@wreise would you be able to help with this?

Sure - it embeds ok. As usual, it's not really centered, but it's something that's unsolved for many elements. What do you think about making it slightly larger? For example 728 x 410 still fits in the "content" part and it makes it look a bit more centered. On the other hand, since the size doesn't adjust automatically to the size nor aspect ratio of your screen, it looks worse on low resolutions. Where do you think it's best to bring it?

Also would like feedback on position. My opinion is that the video should be quite prominent at the very top of the landing page.

Yeah, it's pretty good. I hesitate to suggest adding "meta-content": something like "The guiding principles and illustrative examples are explained in the video and detailed in the sections below.", just above the video. On the other hand, I think it's valuable for the first section to be very concise. What do you think?

ulupo commented 3 years ago

Thanks @wreise! Would you be happy to test some of the options in https://github.com/readthedocs/readthedocs.org/issues/879? Seems maybe with some of them you can set a relative size?

As for position/text, perhaps I slightly prefer no text -- the video title says it all I think.

wreise commented 3 years ago

Ok! Thanks for the pointer - it works as a charm :)

ulupo commented 3 years ago

I agree this looks great, thanks for sorting out the details @wreise!