search

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
858 stars 175 forks source link

[BUG] Possible Error in Topology Time Series Notebook #572

Closed seanlaw closed 3 years ago

seanlaw commented 3 years ago

Describe the bug

In the "From time series to time delay embeddings" section of the Topology Time Series Notebook, it was stated that:

I may be wrong but I think there may be a missing term:

To reproduce

See notebook

Expected behavior

Should show:

Actual behaviour

Currently shows:

ulupo commented 3 years ago

Well spotted! Thanks!

seanlaw commented 3 years ago

@ulupo Would you like me to submit a PR for this?

ulupo commented 3 years ago

Sure @seanlaw, please go ahead!

wreise commented 3 years ago

Ah, I will update the documentation!