API refactor for Mapper plotting functions -- Better support for exogenous color data and more intuitive interface

ulupo commented 3 years ago

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Description Main differences:

color_by_columns_dropdown has been eliminated.
color_variable has been renamed to color_features (but cannot be an array).
Additional kwarg color_data to more clearly separate the input data to the Mapper pipeline from the data to be used for coloring.
node_color_statistic now is applied column by column -- previously the default was just to apply it to whatever (e.g. to a 2d array, thus computing the mean between many features).
Validation has been modularized, and strengthened for the interactive case.
Defaults for colors lead to index values instead of mean of data.
Performance: previously, if we had a transformer to compute colors, this was applied every time in interactive mode. But it suffices to apply it once at the start.
Previously, color_variable failed if a non fitted transformer was passed. Now color_features does not.

Any other comments? I sneaked in a couple of CI fixes as multiple pipelines failed. These fixes are documented in the commit messages.

Checklist

[x] I have read the guidelines for contributing.
[x] My code follows the code style of this project. I used flake8 to check my Python changes.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed. I used pytest to check this on Python tests.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ulupo commented 3 years ago

@wreise I'm aware of the problem with Azure pipelines for manylinux. I feared this moment. Will fix in another PR

ulupo commented 3 years ago

@wreise I've updated the quickstart notebook. Might be a good way to see what has changed until I find the time to write an extensive story.

giotto-ai / giotto-tda