Local homology feature - Githubissues

jacobbamberger commented 3 years ago

Reference issues/PRs

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Added local_homology folder with simplicial file implementing different local Vietoris-Rips persistence objects with tests with full coverage (except plot). Added tutorial notebook in the examples folder.

Screenshots (if appropriate)

Any other comments?

Checklist

[X] I have read the guidelines for contributing.
[X] My code follows the code style of this project. I used flake8 to check my Python changes.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed. I used pytest to check this on Python tests.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

CLAassistant commented 3 years ago

All committers have signed the CLA.

giotto-learn commented 3 years ago

@jacobbamberger , please check these warnings: https://dev.azure.com/maintainers/Giotto/_build/results?buildId=3573&view=logs&j=bd2b5cb2-63a7-5df6-c258-4f0eed6d0bea&t=61277d3e-4d83-5d6d-ca98-417820a07973&l=95157

it seems that hypothesis is trying out some very weird values (I see that you display a warning and automatically adjust the values). Could you constrain the values that hypothesis tries to avoid having these warnings?

jacobbamberger commented 2 years ago

@ulupo I fixed the NLP notebook, but I am not sure how to deal with the test failures...

ulupo commented 2 years ago

@jacobbamberger I've rerun the tests, let's see what they say now.

ulupo commented 2 years ago

@jacobbamberger an example of test failures: https://dev.azure.com/maintainers/Giotto/_build/results?buildId=3629&view=logs&j=852a08b7-9d3b-5d3b-d221-87fcd96267ef&t=c20d12a7-d1d0-585d-e0d4-582facdd3da8

jacobbamberger commented 2 years ago

The eps problem should be fixed now

giotto-ai / giotto-tda

Local homology feature #602