giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python

https://giotto-ai.github.io/gtda-docs

Other

845 stars 173 forks source link

[WIP] Add more citations for historical completness #609

Closed ammedmar closed 2 years ago

ammedmar commented 3 years ago

Description Add more citations, including Morse 1927 and Barannikov 1994

ulupo commented 2 years ago

@ammedmar the description of this PR does not seem to correspond to the actual changes I see in the diff, could you please clarify?

ulupo commented 2 years ago

619 could be fixed in this PR, if it is still active.

ammedmar commented 2 years ago

I added the suggested references for per. entropy and made sure that the claimed changes in the description are in implemented. i.e. new "historical" references for persistence diagram.

ulupo commented 2 years ago

Great, thanks @ammedmar! I may be confused but don't the new chintakunta2015entropy and atienza2020entropy entries also have to be added in bibliography.bib? I don't see them in the diff right now.

ammedmar commented 2 years ago

Oops, yes, I got confused and those bib entries were missing. It is now corrected. Thank you for spotting the error.

ulupo commented 2 years ago

Great @ammedmar! I will add a reference in the docstring and then merge!