search

giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
845 stars 173 forks source link

[BUG] Import FilterFunctionName #633

Closed bioshot-dotcom closed 2 years ago

bioshot-dotcom commented 2 years ago

Describe the bug ImportError: cannot import name 'FilterFunctionName' from 'gtda.mapper.filter'

To reproduce I was in the 3rd cell of the code and an issue cames while running the import of the above function.

from gtda.mapper.filter import FilterFunctionName

Expected behavior

**Actual behaviour**

Versions

Windows-10-10.0.19041-SP0 Python 3.8.3 (default, Jul 2 2020, 17:30:36) [MSC v.1916 64 bit (AMD64)] NumPy 1.22.3 SciPy 1.5.0 Joblib 0.16.0 Scikit-learn 1.0.2 Giotto-tda 0.5.1

Additional context

ulupo commented 2 years ago

Thanks for the question @ireriga98! I see that the notebook is less than perfectly clear there. There in fact does not exist a filter function called FilterFunctionName in gtda, or a clustering algorithm called ClusteringAlgorithm in sklearn.cluster. These are just dummy names to indicate that you can place any class that actually exists there. The non-code cells in our notebooks are not always meant to contain code that can be literally executed. On the other hand, the code cells should always work. So you can take inspiration from/execute the code cells later in the notebook to have something that works. Let me know!

bioshot-dotcom commented 2 years ago

Dear Daniele,

Ok I was thinking it was already ready to be runned, I will try, thank you!

IR

Il mar 17 mag 2022, 18:56 Umberto Lupo @.***> ha scritto:

Thanks for the question @ireriga98 https://github.com/ireriga98! I see that the notebook is less than perfectly clear there. There in fact does not exist a filter function called FilterFunctionName in gtda, or a clustering algorithm called ClusteringAlgorithm in sklearn.cluster. These are just dummy names to indicate that you can place any class that actually exists there. The non-code cells in our notebooks are not always meant to contain code that can be literally executed. On the other hand, the code cells should always work. So you can take inspiration from/execute the code cells later in the notebook to have something that works. Let me know!

— Reply to this email directly, view it on GitHub https://github.com/giotto-ai/giotto-tda/issues/633#issuecomment-1129102594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY3LWR5MLAUON5EP5XPIQZTVKPFULANCNFSM5WFPGL3Q . You are receiving this because you were mentioned.Message ID: @.***>

bioshot-dotcom commented 2 years ago

Sorry for the name, I was meaning Umberto 🙈

Il gio 19 mag 2022, 08:49 ire @.***> ha scritto:

Dear Daniele,

Ok I was thinking it was already ready to be runned, I will try, thank you!

IR

Il mar 17 mag 2022, 18:56 Umberto Lupo @.***> ha scritto:

Thanks for the question @ireriga98 https://github.com/ireriga98! I see that the notebook is less than perfectly clear there. There in fact does not exist a filter function called FilterFunctionName in gtda, or a clustering algorithm called ClusteringAlgorithm in sklearn.cluster. These are just dummy names to indicate that you can place any class that actually exists there. The non-code cells in our notebooks are not always meant to contain code that can be literally executed. On the other hand, the code cells should always work. So you can take inspiration from/execute the code cells later in the notebook to have something that works. Let me know!

— Reply to this email directly, view it on GitHub https://github.com/giotto-ai/giotto-tda/issues/633#issuecomment-1129102594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AY3LWR5MLAUON5EP5XPIQZTVKPFULANCNFSM5WFPGL3Q . You are receiving this because you were mentioned.Message ID: @.***>

ulupo commented 2 years ago

Great! I'll close the issue but feel free to reopen if issues persist!