Closed ulupo closed 2 years ago
Hey @wreise, would you agree with the proposed changes?
Some tests have started to fail, I think pytest
has gotten more adventurous and chooses extremely large parameters -- or some bugs have emerged due to new numpy
/scipy
versions? Anyway, I think fixing the tests is outside the scope of this PR and would think it's better to quickly open a new PR to fix them.
Hey @ulupo , Thanks for the PR! I'd wait for the CI and see if other typos/something easily-fixable comes up.
@wreise thanks! Seems we now at least get to the test stage, and they even pass in Windows with 3.8.
The time has come to end support for Python 3.6. In fact, this was long overdue. The userbase still on Python 3.6 is almost surely insignificant, and we need to concentrate efforts on shipping for Python 3.10 and ARM architectures, which will considerably increase the CI burden.
In passing, I am updating the Windows and macOS VMs on Azure as follows:
scikit-learn
require that then_features_in_
be defined in thefit
method, butBinarizer
andInverter
do not (and they shouldn't necessarily do so).