giotto-ai / giotto-tda

A high-performance topological machine learning toolbox in Python
https://giotto-ai.github.io/gtda-docs
Other
845 stars 173 forks source link

Updating pybind11 #689

Closed rballeba closed 6 months ago

rballeba commented 6 months ago

Reference issues/PRs

Types of changes

Description Updating pybind submodules.

Screenshots (if appropriate)

Any other comments?

I have not executed tests as I have not changed the code. I simply updated a submodule with a newer version to make giotto-tda compatible with newer versions of Python.

Checklist

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

ulupo commented 6 months ago

Hi @rballeba! This sounds good to me. I guess there's the CLA to sign still.

ulupo commented 6 months ago

/azp run

azure-pipelines[bot] commented 6 months ago
Azure Pipelines successfully started running 1 pipeline(s).
rballeba commented 6 months ago

Thank you @ulupo ^^. I think it could be also useful to allow Python 3.11 formally. I would not care to keep working on this project in my free times. If you want, I can try to do it in some weeks.

ulupo commented 6 months ago

You are right @rballeba! The truth is, I have almost no bandwidth to keep being the main maintainer for this project, as I have moved to a different field. If you care for it, I am happy to help.

I would not care to keep working on this project in my free times. If you want, I can try to do it in some weeks.

Just to check that you really mean "you would not care"? :)

rballeba commented 6 months ago

@ulupo I mean, I would love to help with the project :)