giotto-ai / pyflagser

Python bindings and API for the flagser C++ library (https://github.com/luetge/flagser).
Other
13 stars 15 forks source link

Add filtration support #18

Closed reds-heig closed 4 years ago

reds-heig commented 4 years ago

Reference Issues/PRs

16

What does this implement/fix? Explain your changes.

Any other comments?

Add check of filtration if both bindings and python code for available filtrations.

ulupo commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
MonkeyBreaker commented 4 years ago
filtration : string, optional, default: `'max'`
        Algorithm determining the filtration. Warning: if an edge filtration is
        specified, it is assumed that the resulting filtration is consistent,
        meaning that the filtration value of every simplex of dimension at
        least two should evaluate to a value that is at least the maximal value
        of the filtration values of its containing edges. For performance
        reasons, this is not checked automatically.  Possible values are :
            ['dimension', 'zero', 'max', 'max3', 'max_plus_one', 'product',
            'sum', 'pmean', 'pmoment', 'remove_edges', 'vertex_degree']

Is it better this way ?

ulupo commented 4 years ago

@MonkeyBreaker typo in "dtermining", also what I meant is to write 'max' (including the string characters) surrounded by double ticks.

MonkeyBreaker commented 4 years ago

Sorry for the type, i edited previous message

ulupo commented 4 years ago

And take care of the linting after "are: ".

ulupo commented 4 years ago

Double ticks, please. Single ticks are displayed differently by sphinx (they make things look italic).