giotto-ai / pyflagser

Python bindings and API for the flagser C++ library (https://github.com/luetge/flagser).
Other
13 stars 15 forks source link

Missing features from flagser binding #2

Closed reds-heig closed 4 years ago

reds-heig commented 4 years ago

Description

The first version of the bindings for flagser is done in #1. The current python Interface does not support all the possible features described in flagser docs.

The following to-do list report the current status of the missing features (the list is not sorted by priority):

Other useful improvement could be:

This list shall be updated when features are implement and if other missing features should be added.

Regards, Julián

gtauzin commented 4 years ago

Hi Julián,

As of now, I think the priority for the python bindings as well as for the giotto-learn library would be to get rid of the need to go through writing a file on the disk.

For now, I would suggest to have max and min dim, approximate n and undirected support in that order.

Defining a filtration algorithm is more convoluted and we won't need it in the near future.

Thanks!

gtauzin commented 4 years ago

Hi @MonkeyBreaker,

The library is almost ready and I have added support for "modulus" called coeff in the python code.

Would you mind adding support for max and min dim?

reds-heig commented 4 years ago

In my opinion yes, not as I would like to do it (settings in python, then uses settings in c++). What it'll currently do is settings in python and then in cpp transform them as parameters and convert them to arguments.

By the end of the week I should be ready with this, is it good for you ?

gtauzin commented 4 years ago

Yes, I have seen it, I think that's fine for now.

End of the week would be nice, thanks! I think the biggest issue to the release is the windows compatibility described in #4, that would be slightly more pressing.

gtauzin commented 4 years ago

I will close it for now. I think the features present are sufficient. Do not hesitate to open a new issue to request new features.