Fix forwarding arguments for flagser

giotto-ai / pyflagser

Python bindings and API for the flagser C++ library (https://github.com/luetge/flagser).

Other

13 stars 15 forks source link

Fix forwarding arguments for flagser #21

Closed reds-heig closed 4 years ago

reds-heig commented 4 years ago

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Fixes multiples issues where forwarding arguments to flagser.

filtration was not correctly forwarded and it always fallback to zero filtration.
max-dim and min-dim were always equal to 0.
Tests added for the different filtrations
CMakeLists updated to disable AVX instructions and enable compile flags on MSVC

Any other comments?

ulupo commented 4 years ago

@MonkeyBreaker thanks for the fixes! However, can we please also add those tests before merging? It is too important as we have seen, and would reduce review time somewhat.

MonkeyBreaker commented 4 years ago

Sure, I'm preparing and verifying them. But I would like double cross-check when I push them to be sure I do not add more errors ...

ulupo commented 4 years ago

@MonkeyBreaker thanks. Sure, take your time!

MonkeyBreaker commented 4 years ago

Result were controlled with the c++ implementation, same result obtained.

MonkeyBreaker commented 4 years ago

Sure, I'm creating the issues, and if I have some time, try to explore why the segmentation fault is raised.