Closed reds-heig closed 4 years ago
@MonkeyBreaker thanks for the fixes! However, can we please also add those tests before merging? It is too important as we have seen, and would reduce review time somewhat.
Sure, I'm preparing and verifying them. But I would like double cross-check when I push them to be sure I do not add more errors ...
@MonkeyBreaker thanks. Sure, take your time!
Result were controlled with the c++ implementation, same result obtained.
Sure, I'm creating the issues, and if I have some time, try to explore why the segmentation fault is raised.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Fixes multiples issues where forwarding arguments to
flagser
.zero
filtration.max-dim
andmin-dim
were always equal to 0.Any other comments?