search

giotto-ai / pyflagser

Python bindings and API for the flagser C++ library (https://github.com/luetge/flagser).
Other
13 stars 15 forks source link

Allow edges with 0 weight in flagser #28

Closed gtauzin closed 4 years ago

gtauzin commented 4 years ago

Reference Issues/PRs

Fixes #27

What does this implement/fix? Explain your changes.

Any other comments?

gtauzin commented 4 years ago

@ulupo Could you please let me know what is going on with the Azure pipelines? It's passing only on Linux.

ulupo commented 4 years ago

@gtauzin The failure on Windows has to do with linting errors (flake8 is only currently run on Windows). For macOS, it seems we have a compilation error which possibly leads to failure in installing the test environment. See e.g. line 584 in the logs at https://dev.azure.com/maintainers/Giotto/_build/results?buildId=2054&view=logs&j=d7f85de6-3881-56f5-b5c7-a4b11f4f87c0&t=56522ba6-74c9-5ee8-80da-cce8db2512ab&l=584. @MonkeyBreaker do you have any idea what this might be about?

Note: this is now also affecting pipelines running on master. Perhaps an update from Azure is causing this? E.g. a new version of gcc?

MonkeyBreaker commented 4 years ago

You're right, they changed yesterday the compiler version .... https://github.com/actions/virtual-environments/issues/777

I'll look what does this changes involve, I never worked on mac, so, I don't even have a VM with mac on it, will be difficult for me to test.

If someone can try, add to the CMakeLists.txt file, after the project line the following:

I just cannot do it right now, and maybe this could already resolve the issue.

I'll come back as you ASAP. Julián