search

giotto-ai / pyflagser

Python bindings and API for the flagser C++ library (https://github.com/luetge/flagser).
Other
13 stars 15 forks source link

Make Mac pipeline work #29

Closed reds-heig closed 4 years ago

reds-heig commented 4 years ago

Reference Issues/PRs

Exploring why the pipeline fails on mac.

What does this implement/fix? Explain your changes.

Any other comments?

MonkeyBreaker commented 4 years ago

@ulupo, @gtauzin well, as I stated in PR #28, the issue comes because by default the standard used by the c++ compiler is lower than c++11, which is kinda of surprising but I didn't found more information on it.

With this simple fix, all pipelines works. But I would expect that gtda would also fail, I checked and at the moment nothing fails but maybe this fix would need to be implemented there as well.

BTW, the pipeline with pyflagser is much slower than with gtda I think it's due to the test done. For the "bigger" dataset: "medium-test-data.flag", "d10.flag" it takes more time.

I don't know if it's necessary to run them each time, what do you think ?

ulupo commented 4 years ago

Thanks @MonkeyBreaker!

I don't know if it's necessary to run them each time, what do you think ?

I think we can afford doing it for now as we are not pushing too often. I suggest leaving things as they are for now, and we can re-evaluate if and when the need arises.