2 Instead of passing a file to flagser directly give him the data. This allow to not store any data on disk.
What does this implement/fix? Explain your changes.
This PR add support to python bindings for flagser to take as input numpy arrays. Now instead of taking a file as input with vertexes and vertices. Both parameters must be provided separately. Also because it was quite straightforward to implement it, the bindings support directed and undirected flags computation. By default it computes directed computation.
Any other comments?
The input description parameters of the python bindings must be updated so that users understand to what each input correspond.
At the moment the python bindings for the method to compute flagser with a file as input, was renamed flagser_file. While I completely understand that is not a nice name, I didn't have any better ideas, you're more than welcome to provide a better name :)
Reference Issues/PRs
2 Instead of passing a file to flagser directly give him the data. This allow to not store any data on disk.
What does this implement/fix? Explain your changes.
This PR add support to python bindings for
flagserto take as inputnumpyarrays. Now instead of taking a file as input with vertexes and vertices. Both parameters must be provided separately. Also because it was quite straightforward to implement it, the bindings support directed and undirected flags computation. By default it computes directed computation.Any other comments?
flagserwith a file as input, was renamedflagser_file. While I completely understand that is not a nice name, I didn't have any better ideas, you're more than welcome to provide a better name :)Regards, Julián