Add support for a battleship board of size 25 cells; instead of board size being between 6-15, it can be between 6-25 cells.

[sherpabotjohnny[bot]]

Please note, Sherpa may occasionally provide incomplete or inaccurate information. Always verify critical details and double-check suggested changes before implementation.

Summary of the Problem

The issue requires modifying the existing Battleship game to support a board size of 25 cells, expanding the current range from 6-15 to 6-25 cells. This will involve updating the relevant code to ensure that the new dimensions are accepted and properly handled throughout the game logic.

Relevant Files

• AbstractPlayer.java: Contains the logic for player actions, including board setup and ship placement.
• BattleshipSalvo.java: Manages the game flow, including board initialization and player interactions.
• Board.java: Represents the game board and handles the coordinates and display of the board.
• Player.java: Interface that defines the player actions, including setup and reporting damage.
• ViewImpl.java: Handles the console output for the game, including displaying the board and player prompts.

Suggested Changes by File

AbstractPlayer.java

• Lines to modify: Update the setup method to change the height and width range from [6, 15] to [6, 25].
• Guidance: Change the method signature and any checks that enforce the previous limits.

@Override
public List<Ship> setup(int height, int width, Map<ShipType, Integer> specifications) {
    if (height < 6 || height > 25 || width < 6 || width > 25) {
        throw new IllegalArgumentException("Height and width must be between 6 and 25.");
    }
    // existing code...
}

BattleshipSalvo.java

• Lines to modify: Update the initBoard method to accept board dimensions up to 25.
• Guidance: Adjust the conditions that check for valid dimensions.

if (height < 6 || height > 25 || width < 6 || width > 25 || inputs.length > 2) {
    throw new Exception();
}

Board.java

• Lines to modify: Ensure the board initialization can handle the new maximum dimensions.
• Guidance: No major changes should be needed here unless there are specific size-dependent methods.

Player.java

• Lines to modify: Update the setup method's documentation to reflect the new board size range.
• Guidance: Ensure that any implementations of this interface (like RealPlayer and ArtificialPlayer) adhere to the new size constraints.

ViewImpl.java

• Lines to modify: Ensure that user prompts reflect the new valid board sizes.
• Guidance: Update any messages that inform the user about the board dimensions.

view.displayString("Please enter a valid board height and width below (6 to 25):\n");

Conclusion

To implement the change to support a battleship board of size 25 cells, you should focus on updating the relevant methods across the listed files to ensure they accept and validate the new size constraints. This approach will maintain the integrity of the game while expanding its functionality. Make sure to test the changes thoroughly to confirm that all parts of the game handle the new dimensions correctly.