search

giovanism / rook-demo

Apache License 2.0
1 stars 0 forks source link

Add default storageclass in provisioning #2

Closed irvifa closed 4 years ago

giovanism commented 4 years ago

I did add an additional step to annotate the StorageClass as the default class, and the current csi-storageclass.yaml is unmodified from rook's example. If we make another modification should it be mentioned in the readme just like the previous one?

giovanism commented 4 years ago

Too bad in GitHub we can't comment on unchanged codes.

irvifa commented 4 years ago

Right.. probably we should, but the README is in Bahasa Indonesia meanwhile the code's comment mostly in English. Probably just add step that we add this 2 lines in order to create default storage class. wdyt?

irvifa commented 4 years ago

@giovanism I added it in README as well, although probably we can just add each branch or any modification as YAML file to make it easier instead of using patch command

giovanism commented 4 years ago

I think we must keep it simple without multiple branches. I think this is good enough. I'll merge this for now.