search

giovany2g / codeql-javascript-unsafe-jquery-plugin

https://lab.github.com/githubtraining/codeql-for-javascript:-unsafe-jquery-plugin
0 stars 0 forks source link

Step 8 - Finding jQuery plugin options: final step #8

Closed github-learning-lab[bot] closed 4 years ago

github-learning-lab[bot] commented 4 years ago

Step 8: Finding the jQuery plugin options

Now we want to finally find the jQuery plugin options. These are the last parameter of the functions that we found in the previous step.

github-learning-lab[bot] commented 4 years ago

:keyboard: Write your query

Edit the file plugin-options.ql and copy there your previous query.

  1. Modify your from clause so that the variable that describes that jQuery plugin is of type DataFlow::FunctionNode. As the name suggests, this is a data flow node that refers to a function definition. By typing this variable with this type, your query will restrict the possible values for your plugin variable to this type only.
  2. Use auto-completion on that variable to browse the predicates of DataFlow::FunctionNode and find the one that will get you the last parameter of that function.
  3. Your return variable should be of type DataFlow::ParameterNode

Submit your query.

github-learning-lab[bot] commented 4 years ago

Congratulations, looks like the query you introduced in cda04a41fd1fb3bde0f99ee4b5bf20d5f5ef3157 finds the correct results!

Take a look at the instructions for the next step to continue.