search

giovp / spatialdata-sandbox

GNU General Public License v3.0
9 stars 14 forks source link

remove outdated keyword argument visium #35

Closed melonora closed 6 months ago

melonora commented 6 months ago

A keyword argument that does not exist anymore was used when creating the .zarr from downloaded visium data.

LucaMarconato commented 6 months ago

Actually it's referring to an argument that is not merged yet 😅 https://github.com/scverse/spatialdata-io/pull/107/files

But thinking about this, maybe a better behavior is to let the user pass the full path for non-raw files. Or maybe not. What do you think guys? (also, please leave a review in the PR above).

melonora commented 6 months ago

hmm I would indeed do that perhaps with a default argument.