search

giovtorres / docker-centos7-slurm

Slurm Docker Container on CentOS 7
MIT License
85 stars 57 forks source link

Lmod / module support #23

Open rkdarst opened 3 years ago

rkdarst commented 3 years ago

I just added Lmod support and an example hello modulefile, that adds in hello-world script that does the obvious.

While this isn't exactly Slurm, I guess many Slurm setups use this, so would you be interested in taking it upstream?

It is findable here: https://github.com/AaltoSciComp/docker-centos7-slurm/ (on master currently, no direct link to the commit since I am likely to rebase)

giovtorres commented 2 years ago

This looks good! What if we were to put contributions like this in a contrib folder in the project, and place shell scripts there that adds functionality, like adding Lmod support?

That way, once a user uses the container, they can easily add things by executing the scripts, while other users can, by default, choose not to include it if not needed.

Thoughts?