search

gioxx / MarvellousSuspender

A chrome extension for suspending all tabs to free up memory, based on the original TGS 7.1.6, without tracking. Find more information about that on https://gioxx.org/tms
https://go.gioxx.org/download-tms
GNU General Public License v2.0
1.05k stars 84 forks source link

Incompatibility with experimental Chrome "Tab Groups Save and Sync", restored suspended tabs are replaced with 'New Tab's #229

Open TheOverpassArsonist opened 7 months ago

TheOverpassArsonist commented 7 months ago

Please complete the following information when submitting a feature request or bug report.

When using the chrome feature "Tab Groups Save and Sync" enablable in chrome::flags any suspended tabs that are part of a 'hidden' (which as far as I can tell means closed) group and then restored are replaced with new tabs. Non-suspended tabs are restored as-expected, but any suspended tabs are either not saved properly or not restored properly.

While suspended tabs do take less resources, being able to outright close tabs and restore them does still confer many advantages. Notably it makes organization much easier but even suspended tabs do still eat some resources so for managing lots of tabs being able to leverage both suspension and group saving would be desirable.

mattdrewry commented 6 months ago

Just to say I'm having problems with this too. Once I've clicked 'Save group' in Chrome I am unable to reactivate any tabs already sleeping, nor am I am to 'Suspend this tab now' as on click, nothing happens.

It would be great to be able to use both these feature side by side

msva commented 6 months ago

By the way, chrome's group preview menu marks marvellous-suspended tabs as "Unsavable": Screenshot_20240309_203124

ZampolitGL commented 5 months ago

Same here as mattdrewry Extension version: v7.1.6.2 Browser : Chrome Version 123.0.6312.106 (Official Build) (64-bit) Windows 10

TheOverpassArsonist commented 4 months ago

for what it's worth, in the issue which mentioned this one I discovered some oddities around this and found something that I think might be relevant https://support.google.com/chrome/thread/256207412/tabs-of-local-pdf-files-are-unsavable-in-saved-groups?hl=en in this issue on google someone notes that they had tabs of local files (i.e. : not websites) grouped that they typically closed and reopened, but once the tab saving feature was added now the tabs are marked as "unsavable" and open to new tabs as well. Since this is just a post on a google support form and not an actual issue request it's important to be mindful that what's said might not mean the exact words of what is being said, so I think what this is essentially saying is that they used to have many tabs of local files grouped, they would close their browser, (or maybe just click to fold/unfold the tabs?) then the next time they opened their browser they would reappear. Now however they noticed the tab save feature and using it turns their locally saved pdf files into new-tabs if they try to use that feature. (I believe they're likely conflating what they used to do with something else though, as closing the browser restores them fine and folding the group restores them fine)

Testing myself I can confirm that local files are not saved in the tab groups "save" feature, indicating tab groups are unable to access local data for some reason, even if that data is still completely present

This problem is also getting significantly more severe because, while I originally enabled the feature in chrome::flags, now it appears to have officially rolled out and is enabled by default, meaning significantly more people will be unknowingly in danger of getting hit by this. Basically anyone who uses TMS and tab groups are likely to be hit eventually and since chrome (and all derivatives I am aware of) deceptively calls this feature "hiding", most will assume they're not doing anything destructive at all.

Dibface commented 1 month ago

Can confirm, this issue is still present. Closing and relaunching Chrome will delete all saved tabs within a group, replacing them with "New Tabs" instead (marked as "Unsavable Tab").

I'm seeing that there's 4 separate posts on this issue as well... and it seems to be a longstanding issue for a while now (as early as February???)

Will this get fixed...?

Technetium1 commented 1 month ago

No, it will almost certainly not be fixed. See more details: https://github.com/gioxx/MarvellousSuspender/issues/197#issuecomment-2185902490