search

gioxx / MarvellousSuspender

A chrome extension for suspending all tabs to free up memory, based on the original TGS 7.1.6, without tracking. Find more information about that on https://gioxx.org/tms
https://go.gioxx.org/download-tms
GNU General Public License v2.0
1.06k stars 87 forks source link

Google Chrome saved tab groups does not suspect properly #232

Open frankhli843 opened 5 months ago

frankhli843 commented 5 months ago

https://github.com/gioxx/MarvellousSuspender/assets/51806469/01ad2c66-182e-4a67-ac4e-f6615871be21

When tabs are in a group and synced pages no longer suspend

Chrome version: Version 123.0.6312.122 (Official Build) (x86_64) Extension version: v7.1.6.2

MatheusRich commented 5 months ago

This issue is related (or a duplicate of) to #229

TheOverpassArsonist commented 4 months ago

This issue is related (or a duplicate of) to #229

Definitely related but I don't believe duplicate. This video seems to be that tabs inside of "saved" groups literally cannot be suspended, whereas my issue was that tabs that are suspended in groups are either not saved properly when that group is "hidden" (which I still believe means closed, at least I haven't seen anything that counters that) or not restored when the group is pulled back up. There is no way to tell these two things apart from a user facing perspective that I'm aware of so both are possible.

I tested my issue on tabs that I already knew were suspended, that I then put into groups, marked as "saved", "hid", then restored - whereas this is putting them in a group, marking that group as "saved", and then being unable to suspend them. It's a minor difference in theory, but it could end up being relevant if they're not caused by exactly the same thing. So, while it definitely seems like they'd be very closely related, they are different issues that could be unrelated, however unlikely that may be.

This issue actually made me go back again to test an even more niche edge case and, if you have a tab in a group, suspend it, set the group to saved, then swap back to that tab and try to unsuspend it, it won't be able to unsuspend. It won't take you to a new tab page however, it will just sit there trying to unsuspend and failing. However, if you just take a tab in a group, set that group to be "saved", don't go to it, set it to be unsaved, then go to it, it'll unsuspend. I can't say what importance that actually has on solving the issue, but it's a weird enough edge case that it's definitely worth noting since it means suspended tabs aren't inherently "broken" simply by being in a saved group, it is something with the actual saving (and presumably restoring) process that's borked by being in a saved group.