search

gioxx / MarvellousSuspender

A chrome extension for suspending all tabs to free up memory, based on the original TGS 7.1.6, without tracking. Find more information about that on https://gioxx.org/tms
https://go.gioxx.org/download-tms
GNU General Public License v2.0
1.07k stars 87 forks source link

"Not Now" does nothing #86

Open david32 opened 3 years ago

david32 commented 3 years ago

When deciding not to suspend a certain tab, and clicking on the "Not Now" button in the extension window, nothing happens. image

I could help provide some logs or something if you tell me how it should be done.

Also, thanks for taking control of this extension!

witcheries commented 2 years ago

@gioxx

Just to be clear, the 'switch away and then back' process that it was claimed would achieve the 'Not now' state was said to be induced by the following sequence:

Click on 'Not now' -- nothing happens. Click on another active tab in the same window. Return to the first tab. Click again on 'Not now'. This time the 'Not now' condition displays as active.

Is that correct? (That's what I'm finding is not happening.)

That's correct, although the second tab didn't need to be live. It could also be suspended, and the workaround would still work. However, I'm now noticing that the 'Not now' is working as expected, so I wonder if a fix was released?

mkz7 commented 2 years ago

@witcheries

> I'm now noticing that the 'Not now' is working as expected, so I wonder if a fix was released?

I'm not seeing any difference, myself. I click on "Not now' and nothing happens.

And as noted in the post you replied to, even the workaround was no longer working (which continues to be the case for me).

gioxx commented 2 years ago

Ciao @gioxx . . . Was TMS 7.1.6.3 ever uploaded to the Chrome Store?

Ciao @mkz7, sorry for the late reply. No, TMS 7.1.6.3 has not been uploaded to the Chrome Store because I want to avoid the negative comments from those who would go and lose the tab groups, as mentioned several times.

I'm struggling with development because what's being imposed on us by Chrome's Manifest V3 is preventing us from working as we'd like, and we're not sure we can move TMS forward. That said, we will try to focus on saving Tab Groups so we can integrate it with Manifest V2 (I seem to remember it wasn't possible but we'll look at it again) and thus release a good updated version that allows everyone to work properly.

I don't have any release forecasts on this but we are doing what we can in the little spare time to get the task done. If there were more developers out there that could help us, that would be great and allow us to speed up.

Up to now the best solution maybe remains to use the version released here on GitHub (although I realize that you lose the convenience of letting Chrome update it by taking it directly from its Store).

mkz7 commented 2 years ago

> I want to avoid the negative comments from those who would go and lose the tab groups

Thanks, @gioxx. I didn't follow the 'tab groups' issue but couldn't TMS users just be advised to use another extension that saves tab groups until you're able to implement that feature in an updated TMS? (e.g., they could use Tabli for that, which saves tab groups as bookmarks)

If I were to opt to use the Github version, is it necessary to 'uninstall' the current Chrome version or can it just be 'disabled' on the extensions page (red button on the far right)? If not, by 'uninstall' do you just mean use the 'remove' button?

Also, re the last instruction in your 'how to' post -- "Load the "src" folder" -- how is that done? I assume you don't do it by using the same "Load unpacked" button used for the prior instruction (or do you?) . . . https://github.com/gioxx/MarvellousSuspender/issues/86#issuecomment-851895055

Thanks again.

mkz7 commented 2 years ago

Hi @gioxx,

I mentioned Tabli (another tab management extension) in my last post -- as a way that TMS users could save tab groups until you can incorporate that feature in TMS.

I've since recalled that Tabli's developer had included support for The Great Suspender.

When the 'issues' with TGS happened, he indicated that he would do the same for any fork by a "trustworthy developer". So you could contact him to do that with TMS if you would like that to happen.

Tabli provides 'bookmarking' of tab groups, so the TMS users who want that feature could get it in an interim way from Tabli. You could then (if you want to) get a current update of TMS into the Chrome Store for your users, one that includes the 'Not now' fix, and leave the 'tab groups' issue for later.

Just a thought.

TABLI . . . https://chrome.google.com/webstore/detail/tabli/igeehkedfibbnhbfponhjjplpkeomghi

Antony Courtney antony@antonycourtney.com Tabli Dev Team tabli-feedback@antonycourtney.com

CollinChaffin commented 2 years ago

No offense, but it's coming up on a full year since this rather simple code fix was implemented in the github source via/unpack version, yet a year later a MAJOR bug like this still isn't pushed to the Chrome store? I can guarantee that the "complaints" you were facing by releasing this fix, then the other updates, has been FAR exceeded now by those using the webstore extension where one of the few features this extension offers - is 100% broken. I'm curious what metric has you so convinced that releasing two releases, this hotfix, then whatever you've been working on for session mgmgt, would cause the sky to fall to that extent for TMS users?

BTW, I've been using TGS since day one, and NEVER use the session mgmt because for that, I use Session Buddy, which provides session mgmt to a level that TGS/TMS will never possibly achieve - and that's ALL it does. Anyone can install that, save their sessions import/export etc. and never need to worry about "losing" TMS sessions - it's what I do. ALL I want TGS/TMS to do, is tab suspension - and to do it well - that's it.

githubjsorg commented 2 years ago

This is still an issue for me as well.

Technetium1 commented 2 years ago

@mkz7 Uninstallation of the web store version is not required, but disabling it is. If you install the GitHub release any currently suspended tabs will disappear, so be mindful of that. Unsuspend and load them all beforehand, then save the session before continuing with the installation.

Tablii already has an open issue for that here: https://github.com/antonycourtney/tabli/issues/159 and a pull request including TMS ID here: https://github.com/antonycourtney/tabli/pull/165

mkz7 commented 2 years ago

@mkz7 Uninstallation of the web store version is not required, but disabling it is. If you install the GitHub release any currently suspended tabs will disappear, so be mindful of that. Unsuspend and load them all beforehand, then save the session before continuing with the installation.

_Tablii already has an open issue for that here: antonycourtney/tabli#159 and a pull request including TMS ID here: antonycourtney/tabli#165__

@Technetium1 Thanks, Courtney's posts date back quite a while. I doubt he is even involved at all with #159 and #165 at this point.

Given the length of time the 'Not now' issue has remained outstanding, I've concluded that @gioxx is just not going to get to fixing it in the Chrome store version.

Appreciate the information (especially the warning) about the GitHub installation.

mkz7 commented 2 years ago

BTW, I've been using TGS since day one, and NEVER use the session mgmt because for that, I use Session Buddy, which provides session mgmt to a level that TGS/TMS will never possibly achieve - and that's ALL it does. Anyone can install that, save their sessions import/export etc. and never need to worry about "losing" TMS sessions.

@CollinChaffin Saving sessions in TMS seems straightforward enough. Can you say a bit about what makes Session Buddy superior for that purpose?

In the past, every time I looked at the user posts regarding Session Buddy issues, there were a great many complaints about lack of response from the developer. Has that changed?

Thanks.

I-am-the-Users commented 2 years ago

Same :(

Works fine.

mGER86 commented 1 year ago

PUSH

same Problem

suspend

githubjsorg commented 1 year ago

This is still an issue for me but it is inconsistent. Sometimes it works, other times it does not.

sebas-benme commented 11 months ago

Still having this on v7.1.6.2 Chrome: 120.0.6099.71 (Official Build) (64-bit) OS: Windows 11 Version 23H2 (0S Build 22631.2861)

DynamosRose commented 3 months ago

It's 2024 and the "not now" button has never worked for me, with or without workarounds

xodotLBO commented 1 month ago

It's 2024 and the "not now" button has never worked for me, with or without workarounds

Used to work for me but now it stopped, unfortunate.