search

giraffate / clippy-action

MIT License
62 stars 6 forks source link

github-check reporter shows clippy as step under random job #83

Open wmmc88 opened 1 year ago

wmmc88 commented 1 year ago

When using github-check reporter, a PR's checks tab will show clippy-action's check under a random job. 

 - name: Run Cargo Clippy
        uses: giraffate/clippy-action@v1
        with:
          tool_name: Clippy
          clippy_flags: --locked --profile ${{ matrix.cargo_profile }} --all-targets -- -D warnings
          reporter: ${{ github.event_name == 'pull_request' && 'github-pr-review' || 'github-check' }}
          github_token: ${{ secrets.GITHUB_TOKEN }}
          filter_mode: nofilter
          fail_on_error: true

When run with the above config (and triggered by a push), the resulting check will show up under a random job (i think its the first job to start). Example:

image

The above clippy check(triggered by push) is a step in the Lint job, but in the Checks tab of the PR, it shows under the Test Job (on other executions, it shows under different Jobs).