search

giraffe-fsharp / Giraffe

A native functional ASP.NET Core web framework for F# developers.
https://giraffe.wiki
Apache License 2.0
2.13k stars 266 forks source link

Change dev instructions and CI #593

Closed 64J0 closed 6 months ago

64J0 commented 6 months ago

Description

With this PR, I'm proposing a change in the development process, to stop using the develop -> master branch flow, and start using only the master branch.

With this in mind, I'm proposing some changes in the README (+ removing the reference to the night builds, since I think they're not running nowadays), DEVGUIDE and the CI workflows.

Related to the CI configuration, I'm separating the build and test workflow, which must work for all PRs and pushes, from the release workflow, which must run only when a new release is created.

Please let me know what you think.

How to test

Related issues

dbrattli commented 6 months ago

Great. Let's use the opportunity to move to a main branch instead of master since this is the default on GitHub these days

64J0 commented 6 months ago

Great. Let's use the opportunity to move to a main branch instead of master since this is the default on GitHub these days

I like this idea @dbrattli.

Previously I was worried about the impact of this change, for example, the documentation at https://giraffe.wiki/. The contents at this site look pretty much what we have on the markdown files from the master branch. But after looking this code, I think it's going to be easy to update.

Please let me know about other potential impacts that you imagine.

64J0 commented 6 months ago

Reverted the commits to avoid replacing the master branch with main for now.