giraffe-fsharp / Giraffe

A native functional ASP.NET Core web framework for F# developers.
https://giraffe.wiki
Apache License 2.0
2.11k stars 267 forks source link

Add documentation and sample for OpenApi configuration #602

Open 64J0 opened 1 month ago

64J0 commented 1 month ago

Description:

Follow-up from this PR: https://github.com/giraffe-fsharp/Giraffe/pull/599.

We basically need:

nojaf commented 1 month ago

@64J0 are you also on board with moving https://github.com/mrtz-j/Giraffe.OpenApi to https://github.com/giraffe-fsharp?

64J0 commented 1 month ago

@64J0 are you also on board with moving https://github.com/mrtz-j/Giraffe.OpenApi to https://github.com/giraffe-fsharp?

@nojaf +/-, I know the intention exists, but I'm not aware of how the move process is going.

nojaf commented 1 month ago

Well @mrtz-j would need to transfer it (via https://github.com/mrtz-j/Giraffe.OpenApi/transfer) to giraffe-fsharp.

Once that happens I believe some administrator in that organization would need to accept and that would move it. A next step would then be to setup NuGet publishing similar to how it work for the other packages in Giraffe.

mrtz-j commented 1 month ago

I am ready to transfer it. I just need to know if I need to be invited into the organization or if I can simply transfer it and then create PRs to finish the Nuget-setup/README.

nojaf commented 1 month ago

Did you try

image

mrtz-j commented 1 month ago

Yes. I tried to do that, but I got the following error message: You don’t have the permission to create public repositories on giraffe-fsharp.

nojaf commented 1 month ago

Ok, I see. Could you add me as administrator to the repo? I believe I'm admin in the giraffe-org

nojaf commented 1 month ago

@mrtz-j thanks for the invite, I need to be admin on that repo as well to transfer it.

mrtz-j commented 1 month ago

It seems that I can only give you write/read access, but not admin. I'll try to transfer the repo to you instead, and then you can add it to the Giraffe org.

64J0 commented 1 month ago

Imported the repo here: https://github.com/giraffe-fsharp/Giraffe.OpenApi.

mrtz-j commented 1 month ago

I've added some documentation and update the sample app here. It will use the available ENV-variables to push it to NuGet.