search

giraffe-fsharp / Giraffe

A native functional ASP.NET Core web framework for F# developers.
https://giraffe.wiki
Apache License 2.0
2.13k stars 266 forks source link

Update analyzers #623

Closed 64J0 closed 4 weeks ago

64J0 commented 4 weeks ago

Description

With this PR, I'm updating G-Research.FSharp.Analyzers and Ionide.Analyzers nuget package versions, and github/codeql-action/upload-sarif action to v3.

How to test

Check CI.

64J0 commented 4 weeks ago

Noticed that it's not working properly yet, so I'll take more time to understand the problem and fix later.

nojaf commented 4 weeks ago

You need to bump the tool as well:

 [21:46:33.348] error: Trying to load /home/runner/.nuget/packages/g-research.fsharp.analyzers/0.11.0/analyzers/dotnet/fs/G-Research.FSharp.Analyzers.dll which was built using SDK version 0.27.0.0. Expect 0.26.0.0 instead. Assembly will be skipped.
  [21:46:33.369] error: Trying to load /home/runner/.nuget/packages/ionide.analyzers/0.12.0/analyzers/dotnet/fs/Ionide.Analyzers.dll which was built using SDK version 0.27.0.0. Expect 0.26.0.0 instead. Assembly will be skipped.
64J0 commented 4 weeks ago

Closing in favor of dependabot PRs.