Closed dburriss closed 6 years ago
Preferably the template...
Really awesome work! Thank you so much, it really looks good and thanks for even extending the README with the new option (makes my life so easy :))! I had only a few minor questions which I commented above, but overall this looks very good so happy to merge as soon as you also think it's good to go.
Oh, one last question, did you say you included the paket.bootstrapper.exe
and then renamed to paket.exe
? Will this not cause a conflict when the real paket.exe
will be downloaded?
@dustinmoris WRT the rename, see step 3 here: http://fsprojects.github.io/Paket/getting-started.html#Downloading-Paket-s-Bootstrapper It is part of the standard per repository setup for paket "magic mode"
.net core version is in the works. There are still issues around bootstrapper. @enricosada is working on it
Am 24.12.2017 16:55 schrieb "Devon Burriss" notifications@github.com:
@dburriss commented on this pull request.
In src/content/_Default/build.sh https://github.com/giraffe-fsharp/giraffe-template/pull/4#discussion_r158605015 :
@@ -1,3 +1,9 @@ +#if (UsePaket) +if [ ! -e ".paket/Paket.Restore.targets" ] +then
- exec mono .paket/paket.exe install
Still in the works: fsprojects/Paket#2918 https://github.com/fsprojects/Paket/pull/2918
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/giraffe-fsharp/giraffe-template/pull/4#discussion_r158605015, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNGKwEfyXH0T-PgTdhDMYoi1yiJTBks5tDnQHgaJpZM4RLqsT .
Regarding paket.bootstrapper.exe. Yes please commit the 64kb as paket.exe - it will download real paket.exe to temp folder and redirect it to that tool automatically. That's the beauty of magic mode.
Yes definitely. Lock file needs to be shipped.
Am 25.12.2017 10:43 schrieb "Dustin Moris Gorski" <notifications@github.com
:
@dustinmoris commented on this pull request.
In src/content/DotLiquid/paket.dependencies https://github.com/giraffe-fsharp/giraffe-template/pull/4#discussion_r158634127 :
+storage: none +source https://api.nuget.org/v3/index.json + +clitool dotnet-xunit 2.3.1 +clitool Microsoft.DotNet.Watcher.Tools 2.0.0 +nuget Microsoft.AspNetCore.Cors >= 2.0.0 +nuget Microsoft.AspNetCore.Hosting >= 2.0.0 +nuget Microsoft.AspNetCore.Diagnostics >= 2.0.0 +nuget Microsoft.AspNetCore.Server.Kestrel >= 2.0.0 +nuget Microsoft.AspNetCore.Server.IISIntegration >= 2.0.0 +nuget Microsoft.AspNetCore.StaticFiles >= 2.0.0 +nuget Microsoft.Extensions.Logging.Console >= 2.0.0 +nuget Microsoft.Extensions.Logging.Debug >= 2.0.0 +nuget Microsoft.AspNetCore.Authentication.Cookies >= 2.0.0 +nuget Microsoft.Extensions.DependencyInjection >= 2.0.0 +nuget Giraffe >= 0.1.0-beta-600
Ok got it, so after removing all pinned versions we should also include the paket.lock file in the template?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/giraffe-fsharp/giraffe-template/pull/4#discussion_r158634127, or mute the thread https://github.com/notifications/unsubscribe-auth/AADgNAMiB3N3l8KFlpoIC1DTaQYl7SlLks5tD24-gaJpZM4RLqsT .
Referencing issue #1 that kicked off this PR
@dustinmoris just wanted to make sure this isn't waiting on anything more from me?
Hey, no sorry I haven't merged it yet for no particular reason to be honest. I thought I would have another version of Giraffe ready by now and then wanted to release a new version of the template with that new version of Giraffe + your new feature, but the work on Giraffe took me longer than anticipated and then this got a bit delayed. I am in a taxi to the airport now, so will merge this tomorrow latest! Sorry for the delay!
No worries. I just wanted to make sure something wasn't waiting on me.
includes binary, pkaet.lock, etc. as discussed in comments.