search

giraffi / fluent-plugin-amqp

Use AMQP broker to send or receive messages via FluentD
MIT License
15 stars 31 forks source link

Migrate to v0.14 API #33

Closed cosmo0920 closed 7 years ago

cosmo0920 commented 7 years ago

Hi, I've tried to migrate using v0.14 API. Could you consider to start using v0.14 API in this plugin?

Please refer to the upgrading v0.12 to v0.14 guide in more details.

Notice: This PR contains breaking changes.

Since v0.14, fluentd plugins can handle nanosecond order time precision.

sawanoboly commented 7 years ago

Thanks, looks good to me. How about you @warmfusion ?

I will make the release version 0.10.0 because compatibility will be lost.

warmfusion commented 7 years ago

Nice work! I'll need a little time to read through it properly.

As an aside; The reason for the compatibility with 1.9 is due to selfish reasons - we're still using old debian machines with ruby 1.9 which we're slowly upgrading (300+ servers).

I wonder if its possible to operate a 0.10 release which requires 0.14.8+ of FluentD (And Ruby 2.1+) and a 0.9.x release which supports ruby 1.9 and fluent < 0.14... maybe a few branches are in order... I'll have a think.

@cosmo0920 - Thanks again; I'll have a read to understand the changes

warmfusion commented 7 years ago

This looks very good.

I'll merge it in and make a few administrative changes before releasing (CHANGELOG.md and a required_ruby_version to protect users on older installs (ie myself)

cosmo0920 commented 7 years ago

Thanks!