Add nullable annotation to nullable string array parameters in internal methods

gircore / gir.core

A C# binding generator for GObject based libraries providing a C# friendly API surface

https://gircore.github.io/

MIT License

307 stars 28 forks source link

Closed adamreeve closed 3 months ago

adamreeve commented 3 months ago

[x] I agree that my contribution may be licensed either under MIT or any version of LGPL license.

This fixes #1077

I'm not super familiar with the code so let me know if there's a better way to handle this, or if you'd rather just fix it yourself :smile:

badcel commented 3 months ago

Thanks a lot for the PR :rocket:

The code looks fine. Can you Squash your last 2 commits into one, so you have 2 commits left? One for tests and one for the actual code?

adamreeve commented 3 months ago

Yep sure, I've rebased this now.