Use the correct HTML tag type for stylesheets

girder / covalic

Application for hosting challenges

http://challenge.kitware.com

8 stars 3 forks source link

Use the correct HTML tag type for stylesheets #266

Closed brianhelba closed 5 years ago

brianhelba commented 5 years ago

We really need to get a working Vagrant environment for this project.

zachmullen commented 5 years ago

I'm just going to rubber stamp what comes through here for the most part, working under the assumption that you are dealing with testing this and dealing with any breakages in the manner you see fit.

brianhelba commented 5 years ago

To be honest, I'd rather merge without a review if it's a blind rubber stamp. I don't want to trick myself / others into a false sense of confidence. So, if you're not giving real consideration to at least the code content, feel free to abstain.

@danlamanna and I are working on getting better staging environments set up to pre-deploy to for our future use.

zachmullen commented 5 years ago

Does this repo not require an approver before merging? I assumed it did. I'll stop adding reviews if not.

brianhelba commented 5 years ago

There was no branch protection whatsoever on this repo. I just added protection to master, disallowing:

Force push
Fast-forward push outside of PR
Merging PRs with failing status

No reviews are technically required. Of course, for bigger things, we may want to solicit them.

zachmullen commented 5 years ago

Sure. If you're making architectural or data model changes or anything like that, we should do reviews.