Closed jtomeck closed 2 years ago
Merging #27 (1797989) into main (ca8668f) will decrease coverage by
0.77%
. The diff coverage is76.00%
.:exclamation: Current head 1797989 differs from pull request most recent head 55476b1. Consider uploading reports for the commit 55476b1 to get more accurate results
@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 95.55% 94.78% -0.78%
==========================================
Files 14 14
Lines 608 633 +25
==========================================
+ Hits 581 600 +19
- Misses 27 33 +6
@banesullivan Sorry I couldn't get further on this, but I've been spinning my wheels without the knowledge to be more complete. I've left a bunch of comments on the state of things. Let me know if you have any questions, or if there's anything I can do to push this further.
The current UI is really coming along and it is close to feature complete.
@jtomeck, would you please address:
Currently, it looks like:
@banesullivan in order to ensure the box did not get too tall, I've restricted the dimensions of the thumbnail. I forced it inside a 200px square so that the height and width can not be larger than that. So a 400px x 300px thumbnail will be sized to 200px x 150px and there will be black bars on the top and bottom since it does not fill the entire area. I thought that was a good compromise to get the desired functionality for the scrollbar on the left controls.
I had a question after interacting with this for a bit. When you select a band, set the color map, then close it or open another band, it resets the form in the block for the originally selected band. Is this intended behavior? Is there a chance a user might walk away and forget what color map they chose for it?
When you select a band, set the color map, then close it or open another band, it resets the form in the block for the originally selected band. Is this intended behavior? Is there a chance a user might walk away and forget what color map they chose for it?
You're exactly right - we want those choices to persist. I think that's the last thing to do before this is finished
This PR improves the styling of the controls interface.
Resolves #12