girder / django-large-image

🩻 🗺️ Django endpoints for working with large images for tile serving
Apache License 2.0
59 stars 3 forks source link

Controls improvements #27

Closed jtomeck closed 2 years ago

jtomeck commented 2 years ago

This PR improves the styling of the controls interface.

Resolves #12

jtomeck commented 2 years ago
Screen Shot 2022-04-29 at 5 18 06 PM
codecov[bot] commented 2 years ago

Codecov Report

Merging #27 (1797989) into main (ca8668f) will decrease coverage by 0.77%. The diff coverage is 76.00%.

:exclamation: Current head 1797989 differs from pull request most recent head 55476b1. Consider uploading reports for the commit 55476b1 to get more accurate results

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   95.55%   94.78%   -0.78%     
==========================================
  Files          14       14              
  Lines         608      633      +25     
==========================================
+ Hits          581      600      +19     
- Misses         27       33       +6     
jtomeck commented 2 years ago

@banesullivan Sorry I couldn't get further on this, but I've been spinning my wheels without the knowledge to be more complete. I've left a bunch of comments on the state of things. Let me know if you have any questions, or if there's anything I can do to push this further.

banesullivan commented 2 years ago

The current UI is really coming along and it is close to feature complete.

@jtomeck, would you please address:

banesullivan commented 2 years ago

Currently, it looks like: Screen Shot 2022-05-11 at 11 40 55 AM Screen Shot 2022-05-11 at 11 40 57 AM Screen Shot 2022-05-11 at 11 41 00 AM Screen Shot 2022-05-11 at 11 41 06 AM Screen Shot 2022-05-11 at 11 41 23 AM Screen Shot 2022-05-11 at 11 41 13 AM Screen Shot 2022-05-11 at 11 41 47 AM Screen Shot 2022-05-11 at 11 41 57 AM

jtomeck commented 2 years ago

@banesullivan in order to ensure the box did not get too tall, I've restricted the dimensions of the thumbnail. I forced it inside a 200px square so that the height and width can not be larger than that. So a 400px x 300px thumbnail will be sized to 200px x 150px and there will be black bars on the top and bottom since it does not fill the entire area. I thought that was a good compromise to get the desired functionality for the scrollbar on the left controls.

UI recording

jtomeck commented 2 years ago

I had a question after interacting with this for a bit. When you select a band, set the color map, then close it or open another band, it resets the form in the block for the originally selected band. Is this intended behavior? Is there a chance a user might walk away and forget what color map they chose for it?

banesullivan commented 2 years ago

When you select a band, set the color map, then close it or open another band, it resets the form in the block for the originally selected band. Is this intended behavior? Is there a chance a user might walk away and forget what color map they chose for it?

You're exactly right - we want those choices to persist. I think that's the last thing to do before this is finished