search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

Add TOTP support #108

Closed subdavis closed 5 years ago

subdavis commented 5 years ago

Screenshot_20190405_151407

The only issue I see here is the mask ###### which will break if the OTP length changes. It would be nice to include that information somehow in the authentication response if in the future users can configure the strength of token they want.

resolves #107

jeffbaumes commented 5 years ago

Cool! Since I've never heard of the phrase "TOTP token", maybe have it say something more user-friendly like "One-time password"?

zachmullen commented 5 years ago

Should we add a prop for showing the OTP field from the get-go if downstreams know in advance that OTP is required? That way only one login request would need to be made, and users would know they have to fill out both fields.

subdavis commented 5 years ago

@zachmullen I think that's a reasonable override. I'll name that forceOtp with default false.

subdavis commented 5 years ago

Update: small issue with form validation. I'm fixing it now.

subdavis commented 5 years ago

Added optional force prop. Changed TOTP Token to Authentication Code.

brianhelba commented 5 years ago

Can we get a release which includes this PR?