search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

Move build-time packages to devDependencies #129

Closed zachmullen closed 4 years ago

zachmullen commented 5 years ago

It seems like these should be in devDependencies, so I'm assuming this was just an oversight.

matthewma7 commented 5 years ago

I took a quick look of the test errors, I don't know if they are caused by @vue/test-util upgrade or Vuetify upgrade. @vue/test-util caused some problem in ResonantGeo, but Vuetify upgrade should be ok because I upgraded Vuetify in another PR. Is it possible to manually move these two to dev without touching yarn.lock?

subdavis commented 4 years ago

Looks like this has been done in #154