search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

Change from spread syntax to Object.assign #183

Closed HastingsGreer closed 5 years ago

HastingsGreer commented 5 years ago

We had significant issues with vue-template-es2015-compiler versioning, that came down to (unsuccessfully) allowing spread syntax to work in this file. Could we just change it to an Object.assign? Thanks!

zachmullen commented 5 years ago

We use the spread operator in many places in this library, so it will be difficult to keep future developers from adding it indiscriminately. Seems like it would be better to solve your downstream build issue, or as @subdavis has suggested in the past, ship a transpiled version of this library.

EDIT: Of course, you can also use the ES5 UMD module that is in the dist directory of the published package, but then you won't get tree shaking.

subdavis commented 5 years ago

@HastingsGreer what version of vue-template-es2015-compiler are you using?

zachmullen commented 5 years ago

Also if you post the error message you're seeing it could help diagnose your build configuration problem.

zachmullen commented 5 years ago

I'm going to close this as rejection of this particular change, but feel free to continue to discuss the issue, or if there's some other fix we should do, please open an issue.