girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

possible fix #189

Closed subdavis closed 3 years ago

subdavis commented 4 years ago

@zachmullen here's a possible fix that doesn't involve toggling the hash string.

It's based on the assumption that

It simply swaps the order of how the token is obtained such that resetting the hash string is not conditional.

zachmullen commented 4 years ago

This is a reasonable candidate solution, but I still don't feel good about us reaching in and messing around with location.hash as soon as a GirderRest client is instantiated. The GWC library doesn't assume a router or anything, so messing with location.hash at all feels dirty to me.