search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

upgrade to vuetify 2.2.4 #215

Closed subdavis closed 4 years ago

subdavis commented 4 years ago

I feel like every successive update turns vuetify into a more and more quirky codebase, and I'm really starting to wonder if they've just lost control of the scope of the project and the organization is insufficient for the complexity they're managing.

I talked to Jared for a while and we are both really disappointed by the rigidity and high cognitive load of the v-row and v-col grid system compared to v-container and v-layout. I'm about 1 free afternoon away from trying to replicate the 1.X v-container and v-layout components clean-room style in pure flexbox CSS. Prepare yourselves for girder-container and girder-layout.

I also don't know how it makes sense that, if I specify a slot for the header, I also have to remember to disable the default header or else I get 2 headers. That's not a sane default.

/rant

Upgrades to Vuetify 2.2.4

cc @HastingsGreer: I was not able to reproduce your error within the demo app with this upgrade. This PR will, however, make your downgrade impossible. So we'd have to get to the bottom of that issue.

EDIT: I'm actually able to reproduce it in the unit tests. Fix hopefully incoming.

subdavis commented 4 years ago

@zachmullen added the fix for Hasting's issue since that's the reason for this PR.

Edit: Merge this after the previous two to get them included in the release.