search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

Add ToC to demo app #223

Closed zachmullen closed 4 years ago

zachmullen commented 4 years ago

This also contains a couple minor tweaks to the demo page, and changes the job list component to say just "Jobs" instead of "Girder Worker Jobs" since jobs are technically independent of Girder Worker.

zachmullen commented 4 years ago

Closes #222

I got the following form of pug lint failures at first:

38:11   Static attribute "id" must be written as ID literal

Right, I'm supposed to use # notation. The problem is, after doing that, I get:

38:10   ID literals must not be used

I understand that rule for components, but I don't see a way around it if we want to use anchors. My inclination would be to just disable this rule globally, but that feels heavy-handed. What do you think @subdavis ?

subdavis commented 4 years ago

My inclination would be to just disable this rule globally

Do it. I'm starting to see merit in the argument against pug #161

It was fine when I used to work entirely in pug. Moving between pug and html is jarring now. I think whatever decision you make will be a temporary fix while we find the courage to re-write the templates in regular html. Conversion should be pretty easy.

zachmullen commented 4 years ago

Agreed, as time goes on it looks like pug is losing the battle for market share.