search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

Use HTML for templates instead of pug #238

Closed zachmullen closed 4 years ago

zachmullen commented 4 years ago

Fixes #161

zachmullen commented 4 years ago

The test failures here are not a result of pug to HTML migration, but rather are a result of yarn upgrade. I haven't tracked down exactly which upgrade caused it. I suspected vue-async-computed, but downgrading that did not fix the failures.

zachmullen commented 4 years ago

I backed out all the package upgrades, so this is now ready for review. I'm going to open a separate issue to address the upgrade issue I uncovered, but it shouldn't be encumbered by this large and unrelated PR.

One thing I'm unsatisfied with on this PR is that the auto-formatter I used output HTML tags with weird nesting, and then the linter's autofixing didn't adequately address the tag nesting, at least not in any way I find sensible. Furthermore, it expanded all the tags that didn't have a value part, e.g. rather than just say small it expanded all such attributes to small="small", which is ugly and non-idiomatic for Vue.

I can try to address that on this PR by fiddling with the linter config, otherwise I can push it to another PR to isolate those changes.