search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

Allow preUpload to update dest #259

Closed jordansren closed 4 years ago

jordansren commented 4 years ago

When uploading files dest gets set before the preUpload function can make any changes to dest. This change will allow preUpload to potentially update dest, while keeping dest the same if preUpload does not make any updates to it.

zachmullen commented 4 years ago

(Also this is an area where typescript would be super helpful in documenting the behavior of a user-provided function argument.)

subdavis commented 4 years ago

@zachmullen Nope, this level of detail isn't documented.

Agree, a partial rewrite in typescript would provide a lot of value.

subdavis commented 4 years ago

@jordansren please add a patch version bump in package.json to trigger an NPM release.

2.2.3 is appropriate, I think.