search

girder / girder_web_components

Reusable Javascript and VueJS components for interacting with a Girder server.
https://gwc.girder.org
Apache License 2.0
16 stars 9 forks source link

v2.3.1 #300

Closed scottwittenburg closed 3 years ago

zachmullen commented 3 years ago

Tag has been pushed. 2.3.1 should be published in a few minutes.

scottwittenburg commented 3 years ago

Tag has been pushed. 2.3.1 should be published in a few minutes.

Thanks for the lightning fast action @zachmullen 😁

subdavis commented 3 years ago

@scottwittenburg @zachmullen 2.3 was an unintended release, and I was planning to scrub it from NPM pending a discussion.

The changes introduced in #293 are significant enough to require a major version update, so I was going to suggest moving to 3.0.0 after https://github.com/girder/girder_web_components/pull/297 gets resolved, which I haven't had time to fix.

Do you need the changes introduced in 2.3.0 (ts, import restructure)?

We can certainly keep going with 2.3, but it would somewhat contradict semver guidelines.

subdavis commented 3 years ago

I see, the point was to release the changes from #299.

@scottwittenburg you should know that upgrading to 2.3 will break your project.

This library hasn't had so much traffic that it has been necessary to maintain a "stable" branch and a "next" branch to allow us to push minor patches like #299 while working on larger changes.

Apologies for the confusion. Let me know what you want do now.

zachmullen commented 3 years ago

I don't have a strong preference.

scottwittenburg commented 3 years ago

@subdavis We're currently on 2.2.6 and we're only using only the user login/registration dialog in our application, I don't think we necessarily need anything from 2.3, other than the newer axios. And based on your last comment, it sounds like getting that change will require some other work.

Other than that, I don't have any preference which path you take. But when you decide what you're going to do, I'll get in touch about the path forward for my application. Thanks!

subdavis commented 3 years ago

Unless someone has a better suggestion, I'm going to

scottwittenburg commented 3 years ago
  • Write a short migration guide (should be easy, just have to change import paths)

That would be great, thanks!